Michael Mann
changed
bug 9217
| What |
Removed |
Added |
| Attachment #11783 is obsolete |
|
1
|
| Attachment #11783 Flags |
review_for_checkin?
|
|
Comment # 17
on bug 9217
from Michael Mann
Created attachment 11859 [details]
STANAG 5066 dissector
I committed the CRC functions to r52774 to make the dissector patch simpler,
but the dissector itself needs work.
This current patch includes some changesd (most notibly the encoding argument
conversion), but it's not complete.
1. Remove the (non-preference) global variables. They should just be function
parameters to the subdissecting functions.
2. If CRC is returned in little-endian value, then the value should be checked
in little endian (tvb_get_letohl) so cpdu_crc doesn't need to be "swapped".
3. What platform did you compile this on? I'm guessing Windows and "more
picky" compilers may complain with more warnings. I only have a Windows
compiler too, but experience says gcc will generate more warnings (unused
function parameters that don't have _U_ with them). If someone has access,
please post the compiler warnings here.
You are receiving this mail because:
- You are watching all bug changes.