Graham Bloice
changed
bug 9195
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
IN_PROGRESS
|
| Ever confirmed |
|
1
|
Comment # 4
on bug 9195
from Graham Bloice
Great work Chris, I have one really picky comments and two observations:
1. The numeric case label for setting the info column text when reading device
attributes upsets my OCD. Yes I know Anding 0x0000 with 0xFF00 is pointless,
but maybe let the compiler work that one out.
2. The read of IIN could be improved to actually break out the semantic bit
positions rather than just their 0/1 values. I know it didn't do this before
you touched the area but ...
3. To see any of the device attribute values you have to expand the point tree
all the way. Maybe it would be useful to append the value onto the attribute
description text entry.
None of these would stop me checking in your patch, just wanted your thoughts
first.
You are receiving this mail because:
- You are watching all bug changes.