Guy Harris
changed
bug 9174
| What |
Removed |
Added |
| Attachment #11626 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 8
on bug 9174
from Guy Harris
Comment on attachment 11626 [details]
[PATCH 2/5] tests: skip wireshark GUI tests when X server is not available
(In reply to comment #0)
> 2. tests: skip wireshark GUI tests when X server is not available
That should instead be "skip Wireshark GUI tests when GUI is not available".
"X server is not available" does not imply "GUI is not available". The patch
*does* correctly handle the case of Windows, where the GUI is available if
there is no X server, but doesn't handle the case of Quartz (which we
eventually want to use, e.g. as a result of switching to Qt; a check for
"Darwin" as well as "Windows" would handle that), and I'm not sure whether it'd
handle Wayland or Mir.
You are receiving this mail because:
- You are watching all bug changes.