Tyson Key
changed
bug 9105
Comment # 5
on bug 9105
from Tyson Key
Hi Pascal,
Thanks for the review.
Funnily enough, I had planned to submit a further "patch to the patch"/update,
to fix the superfluous (length-2) bits, but I forgot to update the comments,
and made a mess of my local source trees... (I've got a broken "live" copy of
the main SVN repository, and a frozen, unpacked, recent-ish SVN snapshot which
I apply updates to for compilation, and runtime testing - and the copies of
this code are out of sync, at the moment).
I'll sort that out, and provide that update ASAP.
Tyson.
(In reply to comment #4)
> (In reply to comment #2)
> > Created attachment 11512 [details]
> > An updated version that also dissects ATS length bytes, for visual sanity
> > checking
> >
> > Panic averted, after taking a deeper look at the same trace file...
> >
> > Anyway, just to be certain, and to fill in a mysterious gap in dissection, I
> > ended up implementing support for dissecting the ATS length byte, too.
>
> Hi Tyson,
>
> looks good to me. Just a small thing: as you now remove the SW1SW2 code
> directly in packet-usb-ccid.c, all the (length-2) spread all over the
> packet-rfid-pn532.c file seems a bit mysterious unless you check
> packet-usb-ccid.c. Why not simply put the new constant value (without the
> -2)?
>
> Regards,
> Pascal.
You are receiving this mail because:
- You are watching all bug changes.