[bugzilla-daemon@xxxxxxxxxxxxx]

Pascal Quantin changed bug 9105

What	Removed	Added
Status	UNCONFIRMED	IN_PROGRESS
CC		pascal.quantin@gmail.com
Ever confirmed		1

Comment # 4 on bug 9105 from Pascal Quantin

(In reply to comment #2)
> Created attachment 11512 [details]
> An updated version that also dissects ATS length bytes, for visual sanity
> checking
> 
> Panic averted, after taking a deeper look at the same trace file...
> 
> Anyway, just to be certain, and to fill in a mysterious gap in dissection, I
> ended up implementing support for dissecting the ATS length byte, too.

Hi Tyson,

looks good to me. Just a small thing: as you now remove the SW1SW2 code
directly in packet-usb-ccid.c, all the (length-2) spread all over the
packet-rfid-pn532.c file seems a bit mysterious unless you check
packet-usb-ccid.c. Why not simply put the new constant value (without the -2)?

Regards,
Pascal.

---

      You are receiving this mail because:

• You are watching all bug changes.