Michal Labedzki
changed
bug 9050
| What |
Removed |
Added |
| Attachment #11404 Flags |
|
review_for_checkin?
|
Comment # 10
on bug 9050
from Michal Labedzki
Created attachment 11404 [details]
[PATCH 2] Bluetooth: HCI: Full dissection of EIR/AD and little improve
filtering, cd
Hi,
Thanks for applied, but for "hf_bthci_evt_bd_addr" still needed is
"proto_tree_add_ether()" because in Bluetooth MAC address is in little endian,
so for now Wireshark has degrade in displaying address. (On the other side:
using little endian encoding seems to not work...)
More cosmetic question: "tfs_true_false is not needed for FT_BOOLEAN:
> If the Boolean field is to be displayed as "False" or "True", the
'strings' field would be set to NULL. (README.dissector)
Also there is no difference with or without that (the same behaviour).
You are receiving this mail because:
- You are watching all bug changes.