Evan Huus
changed
bug 8917
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
INCOMPLETE
|
| Ever confirmed |
|
1
|
Comment # 2
on bug 8917
from Evan Huus
A few quick questions/comments:
- Using wmem_new instead of wmem_alloc should simplify allocating
fastser_dataregion structure (removes need for cast and sizeof).
- Why do you do use the ret variable:
ret = dataregion->name;
return ret;
instead of just
return dataregion->name;
?
- If you are always going to be looking up dataregions based on base_address,
you could store them in a wmem_tree instead which will be faster and easier
than a linked list. (A tree may make sense to replace some of your other lists
as well, I haven't looked. I only recently added it during Sharkfest, so it
wasn't available when you originally wrote your dissector).
- If you are going to be looking up dataregion structs to get values other than
the name, it may make sense for the lookup function to just return a struct
pointer, then you can access the various struct members as appropriate.
- You add a bunch of fields to the dataregion struct, but only read two of them
that I can see. I assume they will be used in a later patch?
You are receiving this mail because:
- You are watching all bug changes.