Alexis La Goutte
changed
bug 8863
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
CONFIRMED
|
| Ever confirmed |
|
1
|
Comment # 5
on bug 8863
from Alexis La Goutte
(In reply to comment #4)
> Created attachment 11112 [details]
> Patch to add CAA dissecting to DNS, version 2.
Thanks
>
> Hi,
>
> thanks for your comments. I incorporated most of your feedback. However,
> what's the benefit of replacing
>
> + proto_tree_add_text(caa_tree, tvb, cur_offset, 1, "Tag length: %d",
> tag_len);
> + proto_tree_add_text(caa_tree, tvb, cur_offset + 1, tag_len, "Tag:
> %s", tag);
> + proto_tree_add_text(caa_tree, tvb, cur_offset + 1 + tag_len,
> value_len,
>
> by proto_tree_add_item? The values are already added as items before and can
> be searched for in wireshark. Additionally, then some more hf-fields for tag
> length and tag would be needed. These fields are partially redundant as
> there are already fields for the different tags.
Fields are filtereable (and it is prefered to use proto_tree_add_item, if
somebody need to filter in tag length (or tag), it is not possible with your
code
>
> Furthermore I would like to add a searchable "dns.caa" field so that people
> can look for DNS CAA traffic. How do I do this without adding anything to
> the protocol tree?
It is not possible (or use PROTO_ITEM_SET_HIDDEN(hidden_item), but it not
recommended)
You are receiving this mail because:
- You are watching all bug changes.