Oliver Gasser
changed
bug 8863
| What |
Removed |
Added |
| Attachment #11092 is obsolete |
|
1
|
Comment # 4
on bug 8863
from Oliver Gasser
Created attachment 11112 [details]
Patch to add CAA dissecting to DNS, version 2.
Hi,
thanks for your comments. I incorporated most of your feedback. However, what's
the benefit of replacing
+ proto_tree_add_text(caa_tree, tvb, cur_offset, 1, "Tag length: %d",
tag_len);
+ proto_tree_add_text(caa_tree, tvb, cur_offset + 1, tag_len, "Tag: %s",
tag);
+ proto_tree_add_text(caa_tree, tvb, cur_offset + 1 + tag_len, value_len,
by proto_tree_add_item? The values are already added as items before and can be
searched for in wireshark. Additionally, then some more hf-fields for tag
length and tag would be needed. These fields are partially redundant as there
are already fields for the different tags.
Furthermore I would like to add a searchable "dns.caa" field so that people can
look for DNS CAA traffic. How do I do this without adding anything to the
protocol tree?
You are receiving this mail because:
- You are watching all bug changes.