Wireshark-bugs: [Wireshark-bugs] [Bug 8822] New: HTTP heuristic is expensive when checking binar

Date: Wed, 19 Jun 2013 18:54:15 +0000
Bug ID 8822
Summary HTTP heuristic is expensive when checking binary TCP protocols
Classification Unclassified
Product Wireshark
Version SVN
Hardware x86
OS All
Status UNCONFIRMED
Severity Trivial
Priority Low
Component Dissection engine (libwireshark)
Assignee [email protected]
Reporter [email protected]

Created attachment 11022 [details]
Returns if first byte isn't printable rather than scan to end of line.

Build Information:

--
In a profiled run with FTP traffic, the HTTP dissector looking for the end of a
line of data (which was binary) was taking around 3% of runtime.

The patch I will attach will make the HTTP dissector return immediately if the
first character is not printable, but I don't know the protocol well enough to
be sure that this is safe to do.


You are receiving this mail because:
  • You are watching all bug changes.