Stig Bjørlykke
changed
bug 8515
Comment # 6
on bug 8515
from Stig Bjørlykke
Some comments to the "Remove p1 global variables" patch:
1. Is it possible to use actx->external.indirect_reference and
actx->external.direct_reference for extension_id and object_identifier_id?
This would be more inline with other usage of indirect/direct references.
2. The "do_address" is not per packet, but per selected subtrees. I think we
should have a actx value for subtrees used for gathering this kind of
information instead of using p_get_proto_data.
3. We should make functions for handling the "do_address", which handles all
the magic.
You are receiving this mail because:
- You are watching all bug changes.