Wireshark-bugs: [Wireshark-bugs] [Bug 8740] Bluetooth: Improve HFP dissection

Date: Wed, 12 Jun 2013 10:21:33 +0000

Comment # 13 on bug 8740 from
(In reply to comment #12)
> (In reply to comment #11)
> > Looks like this breaks the build, temporarily with:
> > 
> >   CC     libdissectors_la-packet-bthfp.lo
> > packet-bthfp.c: In function 'dissect_at_command':
> > packet-bthfp.c:875:22: error: 'col_str' may be used uninitialized in this
> > function [-Werror=maybe-uninitialized]
> > cc1: all warnings being treated as errors
> > 
> > I don't know if it's the correct/best fix, but it seems that I can
> > temporarily brush it away, so that I can finish building revision 49899 with:
> > 
> > Index: epan/dissectors/packet-bthfp.c
> > ===================================================================
> > --- epan/dissectors/packet-bthfp.c	(revision 49899)
> > +++ epan/dissectors/packet-bthfp.c	(working copy)
> > @@ -872,7 +872,7 @@
> >      proto_item      *pitem;
> >      proto_tree      *command_item;
> >      proto_item      *command_tree;
> > -    guint8          *col_str;
> > +    guint8          *col_str = NULL;
> >      guint8          *at_stream;
> >      guint8          *at_command = NULL;
> >      guint            i_char = 0;
> 
> It is ok. What compiler do you have (32 vs 64bit?, Linux?, gcc 4.4 etc.?)

tyson@tyson-HP-Compaq-2510p-Notebook-PC:~/wireshark$ LANG=en gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/i686-linux-gnu/4.7/lto-wrapper
Target: i686-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro
4.7.2-2ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-4.7/README.Bugs
--enable-languages=c,c++,go,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-4.7 --enable-shared --enable-linker-build-id
--with-system-zlib --libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.7
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object
--enable-plugin --enable-objc-gc --enable-targets=all --disable-werror
--with-arch-32=i686 --with-tune=generic --enable-checking=release
--build=i686-linux-gnu --host=i686-linux-gnu --target=i686-linux-gnu
Thread model: posix
gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1)


You are receiving this mail because:
  • You are watching all bug changes.