Wireshark-bugs: [Wireshark-bugs] [Bug 8740] Bluetooth: Improve HFP dissection

Date: Wed, 12 Jun 2013 10:14:31 +0000

Comment # 12 on bug 8740 from
(In reply to comment #11)
> Looks like this breaks the build, temporarily with:
> 
>   CC     libdissectors_la-packet-bthfp.lo
> packet-bthfp.c: In function 'dissect_at_command':
> packet-bthfp.c:875:22: error: 'col_str' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> cc1: all warnings being treated as errors
> 
> I don't know if it's the correct/best fix, but it seems that I can
> temporarily brush it away, so that I can finish building revision 49899 with:
> 
> Index: epan/dissectors/packet-bthfp.c
> ===================================================================
> --- epan/dissectors/packet-bthfp.c	(revision 49899)
> +++ epan/dissectors/packet-bthfp.c	(working copy)
> @@ -872,7 +872,7 @@
>      proto_item      *pitem;
>      proto_tree      *command_item;
>      proto_item      *command_tree;
> -    guint8          *col_str;
> +    guint8          *col_str = NULL;
>      guint8          *at_stream;
>      guint8          *at_command = NULL;
>      guint            i_char = 0;

It is ok. What compiler do you have (32 vs 64bit?, Linux?, gcc 4.4 etc.?)


You are receiving this mail because:
  • You are watching all bug changes.