[bugzilla-daemon@xxxxxxxxxxxxx]

Michal Labedzki changed bug 8711

What	Removed	Added
CC		michal.labedzki@tieto.com

Comment # 4 on bug 8711 from Michal Labedzki

Hi,
Try check also: tools/fix-encoding-args.pl
epan/dissectors/packet-wifi-display.c (two cosmetic encoding issues)

Regarding not using "call_dissector" - it seems to be convention. "wps",
"wifi_p2p" do the same.

In "wifi_display.subelem.session" couple of fields seems to be true/false
(bit). For example "wifi_display.subelem.dev_info.coupled_sink_by_source"
should not be (FT_BOOLEAN, 16)? Also the highest two bits in this fields is
reserved? Maybe good idea is add field for them (it might look like this:
"Reserved: 0x03"; the same for "wifi_display.subelem.coupled_sink.status" -
this is only cosmetics things, but in this case all bits are dissected)

Also I guess move "static const value_string wfd_coupled_sink_status_bitmap"
slightly higher but below of "static const value_string wfd_dev_info_pc" make
dissector more readable.

Dissector looks fine. Great.

---

      You are receiving this mail because:

• You are watching all bug changes.