Jörg Mayer
changed
bug 8635
| What |
Removed |
Added |
| Attachment #10729 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 8
on bug 8635
from Jörg Mayer
Comment on attachment 10729 [details]
patch against r49209 for wccp and gre enhancements
So looking into the current version with some more time:
- I already asked why you changed some variables from FT_IPv4 to FT_UINT32.
While I now understand that these values are printed via wccp_fmt_ipadddress,
this is not equivalent as we loose the special features that we get by using
FT_IPv4 and FT_IPv6. If would be good to add "normal" addresses via the correct
FT_IPvX types and only print strings when there is a special case (error).
- In find_wccp_address_table: I'm not sure (due to lack of knowledge of the c
standard) that there can't be an integer overflow in the while loop. Anyway
doing an extra check of the item_length when read from the packet would make
sense.
- NOTE_EATEN_LENGTH is probably a tpyo
You are receiving this mail because:
- You are watching all bug changes.