Wireshark-bugs: [Wireshark-bugs] [Bug 8635] New: enhanced WCCP decoder

Date: Wed, 08 May 2013 08:43:59 +0000
Bug ID 8635
Summary enhanced WCCP decoder
Classification Unclassified
Product Wireshark
Version 1.11.x (Experimental)
Hardware All
OS Mac OS X 10.8
Status UNCONFIRMED
Severity Enhancement
Priority Low
Component Dissection engine (libwireshark)
Assignee [email protected]
Reporter [email protected]

Created attachment 10729 [details]
patch against r49209 for wccp and gre enhancements

Build Information:
NA
--
This is an enhanced WCCP decoder handling the new draft 2.01 standard from
http://tools.ietf.org/html/draft-mclaggan-wccp-v2rev1

This decoder handles all documented fields and components including the new
timing components and IPv6. It fails gracefully on bad packets and produces
expert events in case of known errors.

I'm attaching both the patch and the packet-wccp.c file as I reindented it to
preserve my sanity, if possible use the full file as I want to keep this
decoder working.

The code is checkAPI clean and compiles on Unix (gcc and clang) and Windows
platforms.

One ugly hack is that the decoder needs to tell why a packet is wrong, so it
keeps counting the bytes remaining and used so that I can fail with some grace
and diagnostics. The EAT and EAT_AND_CECK macros are ugly and I'm certain that
there is a nicer way of doing this but I could not find it...

As mentioned above I'm interested in maintaining this decoder in future.


You are receiving this mail because:
  • You are watching all bug changes.