Comment # 4
on bug 8489
from David Arnold
(In reply to comment #2)
> Jaap's points are correct. Also:
>
> - there's no need to assert the results of conversation_new or wmem_alloc at
> all, those functions never return null
>
> - please attach a sample capture to test with (and fuzz-testing it yourself
> is recommented, see http://wiki.wireshark.org/FuzzTesting)
I'll remove the assertions. There's something about assuming memory allocation
works that just scares me :-)
I have some sample captures, but I'm trying to get one that covers the whole
protocol. I've tested with editcap -E 0.1 on the captures I have, but I'll
give it a more comprehensive run through once I've got the complete coverage in
a capture.
Thanks -- d
You are receiving this mail because:
- You are watching all bug changes.