Comment # 3
on bug 8489
from David Arnold
(In reply to comment #1)
> Quick review:
> 1) CMakeLists.txt has the wrong filename added
> 2) You could use the PINFO_FD_VISITED() macro
> 3) Never use g_assert in a dissector, use DISSECTOR_ASSERT() macro instead
> 4) never wrap try_conversation_dissector() or dissector_try_heuristic() in
> an 'if (tree)' conditional
Thanks for the feedback. 1-3 seem simple; new patch to follow.
Re: #4, the switch cases for 'U' and 'S' indicate an encapsulated message. Am
I right in thinking that instead of creating the new_tvb inside the 'if (tree)'
block, I should retest for those cases after the 'if (tree)' block, and call
the sub-dissector then?
You are receiving this mail because:
- You are watching all bug changes.