Jaap Keuter
changed
bug 8424
| What |
Removed |
Added |
| Attachment #10155 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 2
on bug 8424
from Jaap Keuter
Comment on attachment 10155 [details]
rtp dissector patch
Quick review:
* No need to include stdio.h
* Clean up the code indentation. The mode lines state: tabs, width 8.
* No // comment lines
* Why changing the order todissect_rtp_hext_rfc5215_onebyte and
dissect_rtp_hext_rfc5215_twobytes first and then trying
rtp_hdr_ext_dissector_table ?
* Resolve your TODO items
* RTP header extension dissector table should not change from BASE_HEX to
BASE_NONE.
You are receiving this mail because:
- You are watching all bug changes.