Evan Huus
changed
bug 8424
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
INCOMPLETE
|
| CC |
|
[email protected]
|
| Ever confirmed |
|
1
|
Comment # 1
on bug 8424
from Evan Huus
Hi Jiri, thanks for the patch. If you could attach a short capture with sample
traffic (for testing), that would be appreciated.
A few notes on your patch:
- The indentation is an inconsistent mix of spaces and tabs. This doesn't
affect the correctness, but it does make it harder to read (and thus for
someone to review).
- You use proto_tree_add_uint in a lot of places where proto_tree_add_item
would probably be preferred
- Wireshark currently doesn't compile everywhere with support for C++ comments
(//). Please replace them with C comments (/* */). Also, please try and comment
in English where possible.
Cheers,
Evan
You are receiving this mail because:
- You are watching all bug changes.