Bill Meier
changed
bug 8240
| What |
Removed |
Added |
| Status |
IN_PROGRESS
|
RESOLVED
|
| Resolution |
---
|
FIXED
|
Comment # 16
on bug 8240
from Bill Meier
Committed with a number of changes in SVN #47247.
Thanks !
Please review the changes. If I've broken anything or made something worse,
please let me know.
Primary changes:
Rework & simplify the reassembly related code;
Revise the display of "message fragments" on the packet details
tree: Essentially: show as "data" only "message fragments" which are
part of a multi-fragment message.
Show the SSL dissection (of a reassembled message) at the outer level of the
packet details tree (not under the OpenVPN/data branch of the tree).
Note: handling "multiple fragments in a frame" has always been difficult; The
solution you implemented for handling reassembly and display on the
packet details tree of multiple fragments in a frame works nicly.
Trying to show information for multiple fragments in a frame on the
"packet summary line" is difficult so I didn't even try to
do something with that.
Bugs fixed:
- Repeated changes of the port prefs would not work properly;
Ports prefs code changed to work in the usual manner.
- Opcode lookup in value_string for COL_INFO "off by 1"
- "Data (-1 bytes)"
- Filter names for hf entries related to reassembly need to begin with
"openvpn".
(Note: it seems that at least some of the revised patches submitted were not
compiled and tested. It would be appreciated if patches are tested before
submission).
You are receiving this mail because:
- You are watching all bug changes.