Comment # 15
on bug 8240
from Manuel Hofer
(In reply to comment #14)
> Ok: I've gone thru the code and fixed a number of bugs.
>
> After looking at the code to do reassembly, I have a question.
>
> It seems to me that fragment_add_seq_next() can be used when reassembling
> openvpn carried over udp (the same as for tcp and rather than
> fragment_add_seq_check()).
>
> If so, this simplifies the code: no conversation tracking required, etc.
>
> I've tried using fragment_add_seq_next() to reassemble openvpn over udp and
> it seems to work OK.
>
> If there's something I've missed which requires the use of
> fragment_add_seq_check() when reassembling openvpn over udp please let me
> know.
>
> If not, I'll commit the code using fragment_add_seq_next() for both.
i remember also using fragment_add_seq_next() for both cases and not getting it
to work properly. after some googleing i found a forum post suggesting the
usage of fragment_add_seq_check() for udp, which then seemed to work also in my
case. maybe this was due to some bugs that have not been fixed at the stage
where i was dealing with reassembly.
if you tested udp and tcp both with and without tls-auth, i see no reason to
not use fragment_add_seq_next() in both cases - you are more familiar with the
wireshark api anyways :)
thanks for your help
You are receiving this mail because:
- You are watching all bug changes.