Wireshark-bugs: [Wireshark-bugs] [Bug 6640] after fix for Bug 3046, after save-as then open you

Date: Mon, 21 May 2012 21:40:00 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6640

--- Comment #6 from Guy Harris <guy@xxxxxxxxxxxx> 2012-05-21 21:39:59 PDT ---
OK, I think the "packet list not displayed" bug should be fixed by rev 42764. 
The changes for bug 4055 were causing problems in the trunk, at least, and I
think in the 1.6 branch; that would be the

> My results w/trunk-1.6 is that after you confirm to overwrite an existing file,
> the current file appears to be closed so that no packets are displayed, but the
> titlebar indicates the name of the newly overwritten file and the 'File ->
> Close' is sensitive, so presumably the intent was for the current file to be
> closed and the newly overwritten file to be created and loaded; however, that
> doesn't happen.

problem.  That change should be scheduled for backporting to 1.6 - and 1.4 as
well, if the fix for 4055 is in the 1.4 branch.

Note, however, that the default behavior of "Save As", in the trunk, is to save
only the displayed packets.  Only a save that saves all the captured packets is
treated as a traditional "Save As" where the current file is the result of the
save, *even if all packets are being displayed*; all others are probably best
thought of as "Export Specified Packets" operations, where the packets are
saved to a new file but the current file isn't changed.

That might explain the

> The behavior with the SVN trunk is different though.  In this case, the file is
> overwritten, but the current file remains open and displayed.  If you want to
> view the new file, you have to manually open it as a separate step.

but, if the change to default to saving displayed packets rather than captured
packets is only in the trunk.

Arguably, "Save As" should *only* be a "save every single packet" operation,
and *always* make the new file the current file, with a separate "Export
Specified Packets" operation that, even if you specify that it should save
every single packet, *never* makes the new file the current file.  That should
clear up that problem (with less pain than tweaking the code that checks for
"did we save everything?" to make the right thing happen if no display filter
is in effect, and with what I suspect will be a user interface clarity
improvement, separating two operations that do different things by design and
intent).

Ken, does the

> The behavior with the SVN trunk is different though.  In this case, the file is
> overwritten, but the current file remains open and displayed.  If you want to
> view the new file, you have to manually open it as a separate step.

behavior still happen in the trunk?  If so, does it do the right thing if you
tell it to save all *captured* packets rather than all *displayed* packets?  If
so, the second problem is what I mention immediately above.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.