https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6733
--- Comment #2 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-01-13 09:13:40 PST ---
Hi,
Please attach the sample and patch in 2 attachements
Quick Review :
There is a lot of warning with checkhf and checkAPIs tools
+ nota_id_msg = tvb_get_guint8(tvb, offset);
+
+ proto_tree_add_item(tree, hf_nota_IARP_message, tvb,
+ offset, 1, nota_id_msg);
the 6th attribut of proto_tree_add_item is the encoding, not the value of item
Also for the enconding, the FALSE / TRUE value is obsolete, need to use
ENC_BIG_ENDIAN / ENC_LITTLE/ENDIAN See Readme.dev guide and also
fix-encodings-args tool.
There is some Clang warning too
packet-nota_down.c:249:3: warning: Value stored to 'addr_family' is never read
packet-nota.c:514:10: warning: Value stored to 'cookie_ptr' during its
initialization is never read
packet-nota.c:594:10: warning: Value stored to 'cookie_ptr' during its
initialization is never read
packet-nota.c:873:5: warning: Value stored to 't_levent' is never read
packet-nota.c:866:5: warning: Value stored to 't_lerror' is never read
packet-nota.c:1406:5: warning: Value stored to 'offset' is never read
packet-nota.c:1396:5: warning: Value stored to 'offset' is never read
packet-nota.c:1386:5: warning: Value stored to 'offset' is never read
packet-nota.c:1401:5: warning: Value stored to 'offset' is never read
packet-nota.c:1391:5: warning: Value stored to 'offset' is never read
The code is fuzzed ?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.