https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6156
Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alexis.lagoutte@xxxxxxxxx
--- Comment #2 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-07-24 04:20:54 PDT ---
Quick Review :
Please add diff of your dissector (see
http://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html#ChSrcDiffWhat
)
Missing the Wireshark header/copyright in top of file
Replace sizeof(guint..) by the value
Also replace the last parameter of proto_tree_add_item by ENC_BIG_ENDIAN
There is some error/warning with checkAPIs
Warning: epan/dissectors/packet-hdfs.c does not have an SVN Id tag.
Error: Found C++ style comments in epan/dissectors/packet-hdfs.c
Error: Found deprecated APIs in epan/dissectors/packet-hdfs.c: dissector_add
And it don't compile under Linux:
packet-hdfs.c: In function ‘dissect_params’:
packet-hdfs.c:80: error: dereferencing pointer to incomplete type
packet-hdfs.c:96: error: dereferencing pointer to incomplete type
packet-hdfs.c:110: error: dereferencing pointer to incomplete type
packet-hdfs.c: In function ‘dissect_data’:
packet-hdfs.c:152: error: dereferencing pointer to incomplete type
cc1: warnings being treated as errors
packet-hdfs.c:141: error: unused parameter ‘pinfo’
packet-hdfs.c: In function ‘dissect_hdfs’:
packet-hdfs.c:210: error: dereferencing pointer to incomplete type
packet-hdfs.c:216: error: dereferencing pointer to incomplete type
packet-hdfs.c:242: error: dereferencing pointer to incomplete type
packet-hdfs.c:249: error: dereferencing pointer to incomplete type
Don't acces directly to tvb->length, use tvb_length function
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.