https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6157
Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #6705|review_for_checkin? |review_for_checkin+
Flag| |
--- Comment #2 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-07-24 04:07:22 PDT ---
(From update of attachment 6705)
Quick Review :
Please add diff of your dissector (see
http://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html#ChSrcDiffWhat
)
Missing the Wireshark header/copyright in top of file
Replace sizeof(guint..) by the value
Also replace the last parameter of proto_tree_add_item by ENC_BIG_ENDIAN
Also there is some error/warning with checkAPIs
Warning: epan/dissectors/packet-hdfsdata.c does not have an SVN Id tag.
Error: Found C++ style comments in epan/dissectors/packet-hdfsdata.c
Error: Found deprecated APIs in epan/dissectors/packet-hdfsdata.c:
dissector_add
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.