Wireshark-bugs: [Wireshark-bugs] [Bug 5067] Patch to add FastCGI dissector

Date: Tue, 17 Aug 2010 01:33:47 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5067

--- Comment #5 from Tom Hughes <tom@xxxxxxxxxx> 2010-08-17 01:33:42 PDT ---
(In reply to comment #4)

> I changed 
> 
>          namelen = tvb_get_ntohl(tvb, offset)
>          ...
>          valuelen = tvb_get_ntohl(tvb, offset)
> 
> to:
>          namelen = tvb_get_ntohl(tvb, offset) & 0x7FFFFFF;
>          ...
>          valuelen = tvb_get_ntohl(tvb, offset) & 0x7FFFFFF;
> 
> since the spec shows that the leading bit is not part of namelen and valuelen
> when they are 4 byte values.
>
> Please verify ....


Yes, that looks correct to me.

> I also added a comment as to a seeming bug in Wireshark tcp_dissect_pdus()
> which seems to prevent appending anything to COL_INFO for the 2nd, 3rd, ...
> FCGI PDU within a TCP frame.
> (I willl file a separate bug for this).

Ah right. Yes, I spent some time trying to find a way to make that work but had
to give up in the end.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.