Wireshark-bugs: [Wireshark-bugs] [Bug 4413] Improve bitview display

Date: Thu, 21 Jan 2010 15:01:11 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

--- Comment #2 from Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> 2010-01-21 15:01:08 PST ---
(In reply to comment #1)
> A few comments to the patch:
> 
> - Selecting bits in the bit view does not always select the correct tree entry.
>   (both integer and boolean values)

Yes I pointed it in my orginal comment:
> (It'd be also good to point good node when clicking single bit.)

Any idea how to fix it? :)

I found:
1/ bit_view_get_byte need to return bit offset instead of byte.
2/ New proto_find_field_from_bitoffset (based on proto_find_field_from_offset)?

> - I don't think we should highlight parts of a byte in hex view.

Ok, I'll remove it.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.