Wireshark-bugs: [Wireshark-bugs] [Bug 4413] New: Improve bitview display

Date: Wed, 20 Jan 2010 13:12:06 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

           Summary: Improve bitview display
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: darkjames@xxxxxxxxxxxxxxxx


Created an attachment (id=4164)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4164)
Add support for bitmasks in bitview

Build Information:
.
--
This patch add support for highlighting part of hex/bits according to bitmask
(currently limited to 1 byte - cause of LE vs BE issues)

There're also some code to fix in dissectors, the easiest to find are:
 - ip.flags.* offsets are incorrect (phased by 5 bits)
 - ip.version should have 0xf0 bitmask, with bitshift 4.
 - ...

It'd be also good to point good node when clicking single bit.
So it's big work in progress..


This patch also splits update of hex display into two phases:
 - make hexdump / bitdump (packet_hex_print_common())
 - highlight bits from selected node (packet_hex_apply_reverse_tag())

I haven't seen aby big performace lost (but with big probability it's slower)

It's possible to make this enhancement works with old code.
But switching reverse/!reverse with old code...

Another idea is to create our own widget/gtktextbuffer (like comment suggest)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.