http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1606
acferen@xxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #679 is|0 |1
obsolete| |
Attachment #680 is|0 |1
obsolete| |
Attachment #940| |review_for_checkin?
Flag| |
------- Comment #5 from acferen@xxxxxxxxx 2007-09-21 20:49 GMT -------
Created an attachment (id=940)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=940&action=view)
Updated patch (addressing earlier comments)
Issue 1 : Memory management
Honestly, I'm not quite sure what was going on there either. I pillaged the
code from packet-tcap.c and didn't give much thought to it. I have removed the
superfluous range variables and it is still working fine. I guess they weren't
needed.
Issue 2 : comments
I wasn't sure what to add here. Hope my minimal comments are sufficient. Let
me know if more detail is needed.
Issue 3 : extract the common parts of proto_reg_handoff_netflow and
netflow_reinit
I should have done this initially. proto_reg_handoff_netflow now calls
netflow_reinit
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.