Wireshark-bugs: [Wireshark-bugs] [Bug 1180] field without name in pdml output

Date: Thu, 26 Oct 2006 12:02:21 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1180


martin.mathieson@xxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #2 from martin.mathieson@xxxxxxxxxxxx  2006-10-26 12:02 GMT -------
The "Root Identifier" field was added using proto_tree_add_text() (see
packet-bpdu.c:418) rather than the preferred method of defining and using an
hf_register_info structure for that field.

The code for printing the PDML text for a node in the protocol tree makes a
special case of nodes created by proto_tree_add_text(), and since there is no
structure to refer to with a name field it doesn't write out anything for that
field (see print.c:251).

According to http://analyzer.mirror.ethereal.com/docs/dissectors/PDMLSpec.htm,
the name field is required.

So - would it be helpful if I changed the text-only case in print.c to write
out 'name=""' ?

Of course, the best long-term solution is to improve those dissectors that you
care about not to use proto_tree_add_text(), which makes proper filtering
possible :)


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.