Ethereal-dev: Re: [Ethereal-dev] Re: [Ethereal-cvs] rev 17789: /trunk/: Makefile.common captur

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 02 Apr 2006 20:51:41 -0700
Ulf Lamping wrote:

May I ask what you are doing here?

I'm fixing things so that if the attempt to dumpcap fails, an error dialog box pops up.

Instead of working towards privilege separation for tethereal, you're doing exactly the opposite by naming things as we don't use a pipe in any way even in the future?!?

The name change does not, in any way, prevent a pipe from being used.

It merely separates the low-level sync_pipe_errmsg_to_parent() routine (which unconditionally writes to the pipe) from the higher-level report_capture_error() routine (which only writes to the pipe in a capture child).

BTW: I've tried to name things so the function/file names are prepended by the capture_ prefix, so it's obvious where the function belongs to. You don't seem to like this at all ...

I don't have any objection to it.