[Ulf Lamping <ulf.lamping@xxxxxx>]

guy@xxxxxxxxxxxx wrote:
> User: guy
> Date: 2006/04/02 08:56 PM
>
> Log:
>  Put the low-level sync routines into a common file so they can be shared
>  by dumpcap and Ethereal (so that, on UN*X, the child process can report
>  a detailed "can't exec dumpcap" error).
>  
>  Rename most of the "sync_pipe_XXX_to_parent()" routines, as they're also
>  in Tethereal, which doesn't have a sync pipe.
>
> Directory: /trunk/
>   Changes    Path                 Action
>   +3 -0      Makefile.common      Modified
>   +19 -19    capture_loop.c       Modified
>   +25 -0     capture_loop.h       Modified
>   +9 -7      capture_sync.c       Modified
>   +0 -53     capture_sync.h       Modified
>   +13 -73    dumpcap.c            Modified
>   +79 -0     sync_pipe.h          Added
>   +110 -0    sync_pipe_write.c    Added
>   +20 -20    tethereal.c          Modified
>
>
>
> http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=17789&view=rev
> _______________________________________________
> Ethereal-cvs mailing list
> Ethereal-cvs@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-cvs
>
>   
May I ask what you are doing here?

Instead of working towards privilege separation for tethereal, you're 
doing exactly the opposite by naming things as we don't use a pipe in 
any way even in the future?!?

BTW: I've tried to name things so the function/file names are prepended 
by the capture_ prefix, so it's obvious where the function belongs to. 
You don't seem to like this at all ...

Regards, ULFL