Ethereal-dev: [Ethereal-dev] Re: Fix problem with DCE RPC fragment reassembly

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Fri, 12 Aug 2005 21:38:34 -0400
There has been recent changes in that code and the two lines you refer
to do not exist in current SVN any more.

Can you try to sync up with current SVN and test your captures if the
bug sill exists or has been fixed already?



On 8/12/05, Tom Kelly <tom.kelly@xxxxxxxxxxxx> wrote:
> Patch against 0.10.12
> 
> The attached patch fixes a problem with fragment reassembly
> for DCE RPC.  It removes two calls on tvb_ensure_bytes_exist().
> 
> When adding a fragment to the fragment list, we are adding
> the entire contents of the current decrypted tvb (which itself may
> have been composed of reassembled frames and possibly decrypted).
> 
> The removed calls were incorrect, passing an offset value that
> was the location of this fragment within the completely
> reassembled DCE RPC message, rather than the location within
> the current tvb of the beginning of the buffer.  Since the
> corrected call used 0 for the offset, and the tvb's length
> as the length, I simply removed them.  With these lines
> removed and the appropriate reassembly options enabled,
> DCE RPC messages composed of multiple fragments are
> reassembled and shown in a tab.
> 
> Thanks so much for ethereal - it is wonderful.
> 
> Tom Kelly
> tom.kelly@xxxxxxxxxxxx
> 
>