Ethereal-dev: Re: [Ethereal-dev] GMM & SM Patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Fri, 14 Jan 2005 03:39:11 -0800
Pilz Rene wrote:

This patch fix the following parts:
- partly wrong cause values in the gmm (found by Miklos Szurdi)
- high/low nibble swap of the force to standby field (found by Miklos Szurdi)
- dissect now all elements

Checked in.

Should the switch statement in "de_sm_pco()" instead first do

	dissector_handle_t *handle;

		...

	handle = dissector_get_port_handle(gprs_sm_pco_subdissector_table, prot);
	if (handle != NULL) {
		proto_tree_add_text(tree,tvb, curr_offset-3, 2, "Protocol: (%u) %s", prot,
		    val_to_str(prot, ppp_vals, "Unknown"));
proto_tree_add_text(tree,tvb, curr_offset-1, 1, "Length: 0x%02x (%u)", e_len , e_len);
		/*
		 * dissect the embedded message
		 */
		l3_tvb = tvb_new_subset(tvb, curr_offset, e_len, e_len);
		call_dissector(handle, l3_tvb, &pco_pinfo, tree);
	} else {
		switch ( prot ) {
			the case statements for values other than PPP protocol types
		}
	}

You'd include "packet-ppp.h" to get "ppp_vals[]" declared.