Ethereal-dev: Re: [Ethereal-dev] Re: packet-pgsql.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 21 Dec 2004 01:21:26 +0100
On Sun, Dec 19, 2004 at 06:48:39PM +0530, Abhijit Menon-Sen wrote:
> I realised that I needed to add g_free() calls for every tvb_get_string*
> call. (Garbage collection really has spoiled me. :-)
> 
>     <http://www.oryx.com/ams/packet-pgsql.c>

Checked in.
I noticed a few thing though: You do not highlight all the data that
belongs to a certain item: You only highlight the Value but not the
keyword (user test - only highlights test).
A nice thing to have would be a configurable port via preferences.

  Ciao
    Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.