["Ronnie Sahlberg" <ronnie_sahlberg@xxxxxxxxxxxxxx>]

----- Original Message ----- 
From: "Guy Harris"
Sent: Saturday, February 21, 2004 8:17 PM
Subject: Re: [Ethereal-dev] kerberos stuff and nettle question


> On Fri, Feb 20, 2004 at 09:17:38PM +1100, Ronnie Sahlberg wrote:
> > beware  i just checked in the completely new rewritten kerberos
dissector
> > together with asn.1 ber helpers in packet-ber.c
>
> Why does "dissect_krb5_PA_DATA_value()" do
>
> if(ber_last_created_item){
> tree=proto_item_add_subtree(ber_last_created_item, ett_krb_PA_DATA_tree);
> }

Its a kludge. I just thought it looked "better" that way. For example when
there are multiple entries in the
preauthentication blob then it would look like :
    Pre-Authentication
        Type: PA-TGS-REQ
            Value:lsjgdfg
        Type: something-else
            Value:kerhtbmsd
and one would not see the values unless one expanded the Type.

The value blobs are associated to the Type fields.


I just though it looked "better" when there are several entries in the
PA-blob.
I do not feel strongly about it.

Please feel free to change it to look like the old kerberos dissector if you
want to.