Ethereal-dev: Re: [Ethereal-dev] SIP: selected packet bytes (resend with patch attached)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 19 Feb 2004 01:41:49 -0800
On Thu, Feb 19, 2004 at 10:18:48AM +0100, Joerg Mayer wrote:
> I'd like to keep sdp at the top level. Is there a reason why some of the
> other protocols don't put it there?

In the case of SIP, it's apparently because Anders Broman didn't want it
there:

	% cvs log packet-sip.c

		...

	revision 1.50
	date: 2003/12/08 20:25:31;  author: guy;  state: Exp;  lines: +224 -170
	From Anders Broman:

	        Call subdissectors regardless of whether we're building a
	        protocol tree or not.

	        Use the "media_type" dissector table to hand off to
	        subdissectors, rather than wiring in SDP.

	        Put the message body into a subtree of the SIP tree rather than
	        at the top level.