Checked in.
Regards,
Olivier
----- Original Message -----
From: Anders Broman
Hi,
I have tried your patch and it looks good, the warnings was there
before:
packet-h225.c
packet-h225.c(10322) : warning C4018: '>' : signed/unsigned mismatch
packet-h225.c(10324) : warning C4018: '>' : signed/unsigned mismatch
register.c
I have included a diff with the patch.
Best regards
Anders
-----Original Message-----
From: Martin Regner
Jonty Ray wrote:
< I Can successfully see it in Ethereal version 0.9.7, which I have
been using till now.
I think that I found something interesting.
The "fastStart item length" is 36 for Item 0, but it seems that the
h225 dissector is not using that information, so it continues
to dissect the next fastStart item without skipping any padding bytes
(at least it seems that there is some kind of padding in your
capture that I haven't seen in other captures).
I tried to do some small modifications i dissect_h225_fastStart_item
so that the new offset is calculated from item length
and that seems to solve the problem. Howver I have just tested with
one capture yet.
The solution below is just the preliminar I used. I need to check more
details regarding this and there is currently a warning
due to unsigned/signed mismatch.
Maybe there is a few other places in the code where you need to do
similar things.