["Olivier Biot" <ethereal@xxxxxxxxxx>]

From: "Lars Ruoff"


| Ok for the retap_packets patch, but rtp_analysis still needed some
of the
| fixes i provided with last patch which wasnt checked in.
| Here is a new patch.
| Please check-in.
| Checked with 2003-01-15 snapshot.

Checked in. See remarks from Guy: we're disabling this code for now.

| However there is an access violation with the 2003-01-19 snapshot
when
| launching rtp streams box. Must be due to some patches to other
parts of
| code outside of rtp_analysis. Please could somebody confirm?

Indeed: the SIP patch I checked in yesterday introduced a double free
bug. This has been fixed half an hour ago.

Regards,

Olivier

| ----- Original Message ----- 
| From: "Guy Harris"
|
| > On Jan 16, 2004, at 9:18 AM, Lars Ruoff wrote:
| >
| > > Also, apparently the tap's reset function didnt get called any
more
| > > with the
| > > change from redissect_packets to retap_packets !? What's the
difference
| > > between the two functions?
| >
| > retap_packets() doesn't reconstruct the packet list, that being
| > something that doesn't need to be done if all you're doing is
| > re-running the taps on the packets.  Not reconstructing the packet
list
| > should make it run faster, and should keep the screen from
flickering
| > when the packet list is redisplayed.
| >
| > I've checked in a fix to make it call "reset_tap_listeners()"
before
| > rerunning the taps.