Attached patch fixes RTP streams tap bugs reported by Olivier Biot.
Please check-in.
Problem was that the tap wasn't unregistered after analysis.
Also, apparently the tap's reset function didnt get called any more with the
change from redissect_packets to retap_packets !? What's the difference
between the two functions? Has this been discussed on the list?
Problem has been fixed but the refresh function will not work the way it did
any more. (had no time to fix that). So i commented out the Refresh-button
entirely.
I consider this a minor problem, since
- Refresh is just a shortcut to closing the box and reopening another one
with same streams.
- i plan to move the refresh function to the rtp_streams dialog box anyway.
----- Original Message -----
From: "Biot Olivier" <Olivier.Biot@xxxxxxxxxxx>
To: "Ethereal-Dev" <ethereal-dev@xxxxxxxxxxxx>
Sent: Friday, January 16, 2004 10:21 AM
Subject: [Ethereal-dev] RTP streams tap bugs
> Hi list,
>
>
> If you use the RTP streams tap of Ethereal, there seem to be some bugs.
Try
> opening the capture posted to etherea-dev in:
>
> http://www.ethereal.com/lists/ethereal-dev/200312/msg00469.html
>
> Open Analyze->statistics->RTP Streams -> Show all.
>
> Selecting (or clicking on "Analyse") only one RTP stream (e.g. the first)
> will show values that seem to have been sign-wrapped or incorrectly
casted.
> Opening a stream twice yields different results (you can compare both
> displays).
>
> Regards,
>
> Olivier
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
Attachment:
rtp_analysis.c.diff
Description: Binary data