Ethereal-dev: Re: [Ethereal-dev] ANSI MAP statistics, fix for point code display

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 10 Dec 2003 20:08:10 -0800

On Dec 10, 2003, at 4:07 PM, Michael Lum wrote:


cvs diff -u from latest cvs source:

packet-ansi_a.c.diff
packet-ansi_a.h.diff
	Moved static const array definition to .h so that
	other dissectors can use it.
Unfortunately, if something that *doesn't* use it includes packet-ansi_a.h, newer versions of GCC (and possibly older versions) give a warning.
Equally unfortunately, if you make it non-static, and just put an "extern" declaration in packet-ansi_a.h, you can't compute the size of the array in source files other than the file in which the size is used can do that.
So perhaps it should be left in packet-ansi_map.c but made non-static, declared extern in packet-ansi_map.h, and removed from packet-ansi_a.c.