On Friday 17 Oct 2003 10:01 pm, Guy Harris wrote:
> On Fri, Oct 17, 2003 at 11:23:42AM +0200, Ulf Lamping wrote:
> > And then change the following menu entries: Move "Colorize display" to
> > the Edit menu item (as it's very similar to Display Filters, and I would
> > expect it there!)
>
> And perhaps change its name to "Packet Coloring Rules", or something
> such as that, as what you're editing are those rules.
>
> However, this raises another question.
>
> You might want to edit your coloring rules and save them, even if you
> don't have a capture file open.
Yes please.
> You might also want to change the coloring rules for the *current*
> capture and save them, independently of your default rules.
>
> If users would find both of those useful, perhaps the former should be
> Edit > Packet Coloring Rules and the latter should be View > Packet
> Colors or something such as that.
But they both bring up the same dialog, with the same functionality. That is
going to cause confusion even if we disable save to default in the "View"
instance.
If people want that functionality, I'd just put it under "Edit" and stop the
OK button saving to default, so you had to do an explicit "Save". But that
could cause confusion too.
IMO having OK, Save, Apply and Cancel on the edit colors dialog is a bit much
anyway. Howabout having just Close, Save and Apply? That would mean two
clicks in just about every case, but it would be more obvious what was
happening.
There is still the problem that all changes made persist in the filter list,
so a subsiquent capture/load would be coloured with the new list even if you
didn't Save or Apply. Maybe that needs fixing.
--
Richard Urwin