Ethereal-dev: [Ethereal-dev] Re: THANKS lot's of warnings: redefinition of symbol 'OPTIONAL'

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Ulf Lamping" <ulf.lamping@xxxxxx>
Date: Fri, 10 Oct 2003 14:22:56 +0200
Guy Harris <guy@xxxxxxxxxxxx> schrieb am 09.10.03 21:01:14:
> 
> 
> On Oct 8, 2003, at 8:08 AM, Ulf Lamping wrote:
> 
> > As the name OPTIONAL isn't very unique, I would suggest to rename 
> > OPTIONAL in file packet-per.h to something like PER_OPTIONAL or such 
> > and change the .c files using this define.
> 
> That sounds reasonable.  Is that form of "optional" PER-specific, or 
> generic to ASN.1?  If the latter, perhaps ASN1_OPTIONAL would be 
> better.  (At some point we might want to look at dissecting ASN.1 BER 
> in a fashion similar to the way we dissect PER.)
> 

Thanks for your effort. 

It reduced the number of msvc warnings from about 160 to 130 :-)

As I didn't even know what the files are for, I didn't know the best prefix, but it sounds reasonable to me.

Regards, ULFL

______________________________________________________________________________
Die Besten ihrer Klasse! WEB.DE FreeMail (1,7) und WEB.DE Club (1,9) -
bei der Stiftung Warentest - ein Doppelsieg! http://f.web.de/?mc=021184