Ethereal-dev: Re: [Ethereal-dev] ITU/ANSI TCAP dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 11 Sep 2003 01:15:34 -0700
On Wed, Sep 10, 2003 at 09:32:40AM -0700, Michael Lum wrote:
> Here's mine as well.
> 
> The file compiled perfectly clean on SPARC with gcc.

It still got some warnings - Jeff Morris' patches fixed them; the
functions

	dissect_ansi_tcap_reject
	dissect_ansi_tcap_re
	dissect_ansi_tcap_rr
	dissect_ansi_tcap_invoke
	dissect_tcap_invoke
	dissect_tcap_rr
	dissect_tcap_reject

need to return "void", not "int".

Also, what is the significance of "asn1_tag_decode_m()"?  The comment
says

/* to make the source file easy to be contributed , override this function */
/* so there is no need to modify asn1.c(with a bug) any more */

Does that mean that "asn1_tag_decode()" in asn1.c is buggy?  If so, then
it should be fixed, not overridden.