Ethereal-dev: [Ethereal-dev] packet-wtp.c: WTP packet sequence number

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Biot Olivier <Olivier.Biot@xxxxxxxxxxxxxxx>
Date: Tue, 26 Nov 2002 19:07:48 +0100
Hi all,

There is an inconsistency in WTP display of packet sequence numbers:

1. In the WTP header, hexadecimal notation is used:

	{ &hf_wtp_header_sequence_number,
	    { 	"Packet Sequence Number",
		"wtp.header.sequence",
		FT_UINT8, BASE_HEX, NULL, 0x00,
		"Packet Sequence Number", HFILL
	    }
	},

2. while in the PacketSequenceNumber TPI, decimal notation is used:

	{ &hf_wtp_tpi_psn,
	    { 	"Packet sequence number",
		"wtp.tpi.psn",
		FT_UINT8, BASE_DEC, NULL, 0x00,
		"Sequence number of this packet", HFILL
	    }
	},

I propose to use hexadecimal (BASE_HEX) for both.

Regards,

  Olivier Biot                     Siemens ATEA IC D MS C
O-------------------------------o-------------------------------O
| Phone   : +32  (14) 25 39 84  |  Address: Atealaan 34         |
| Fax     : +32  (14) 22 29 94  |           2200 Herentals      |
| Cellular: +32 (474) 96 32 09  |           Belgium             |
O-------------------------------o-------------------------------O
~  "I love deadlines.  I especially love the swooshing sound    ~
~   they make as they go flying by."               - Dilbert    ~