Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] cvs commit: ethereal packet-rpc.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Ronnie Sahlberg" <ronnie_sahlberg@xxxxxxxxxxxxxx>
Date: Mon, 18 Nov 2002 20:57:49 +1100
Give Martin an entry in the AUTORS file and tha man page as well to
encourage him.


----- Original Message -----
From: "Uwe Girlich" <girlich@xxxxxxxxxxxxxxxxxxx>
To: <ethereal-cvs@xxxxxxxxxxxx>
Sent: Monday, November 18, 2002 8:35 PM
Subject: [Ethereal-cvs] cvs commit: ethereal packet-rpc.c


> girlich     2002/11/18 03:35:29 CST
>
>   Modified files:
>     .                    packet-rpc.c
>   Log:
>   Since packet-rpc.c 1.56 (ethereal 0.8.18), we store in
>   dissect_rpc_opaque_data() the actual bytes into the dissector data tree
>   (improves searching). But if we only give the string "<DATA>" to the
>   proto_tree_add_* functions and tell it at the same time, that we have
indeed
>   string_length_copy bytes, this leads to problems.
>
>   Correction: give the pointer into the real data and not the pointer to
the
>   print string to the proto_tree_add_string_format() and
>   proto_tree_add_bytes_format() functions.
>
>   The correction was found by Martin Regner.
>
>   Revision  Changes    Path
>   1.109     +3 -3      ethereal/packet-rpc.c
> _______________________________________________
> Ethereal-cvs mailing list
> Ethereal-cvs@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-cvs