Ethereal-dev: Re: [Ethereal-dev] LDAP desegmentation fix...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxx>
Date: Tue, 12 Nov 2002 13:38:31 -0800
On Mon, Nov 11, 2002 at 03:53:08PM -0500, Ronald Henderson wrote:
> I have fixed a bug that occurs with the LDAP dissector when desegmentation
> is enabled.

Checked in.

> I have included a diff output

"diff -c" or "diff -u" output would be better, as it includes some
context, so that if the current CVS version isn't the same as the
version you modified, the change can often still be applied
automatically by the "patch" program.

Also, making the patch an attachment keeps mail software from
"helpfully" splitting lines, as happened to your patch:

> E:\src\ethereal\ethereal-0.9.7>diff packet-ldap.c packet-ldap.c.org
> 41,49d40
> < /*
> <  * 11/11/2002 - Fixed problem when decoding LDAP with desegmentation
> enabled and the
> <  *              ASN.1 BER Universal Class Tag: "Sequence Of" header is
> encapsulated across 2
> <  *              TCP segments.