Ethereal-dev: Re: [Ethereal-dev] Filtering on http commands (help needed)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 23 Aug 2002 22:50:31 +0200
On Fri, Aug 23, 2002 at 03:00:40PM -0400, Khachaturov Vassilii wrote:
> I'd call this thing method rather than command throughout the code and esp.
> the filter names. This way it's closer to the RFC... 

Thanks! I've done that now.

> Code-wise you could probably extend the 
> is_http_request_or_reply() routine to return you the method string (ether
> as a sub-tvb or as a pair of (offset, length) into the line given)
> because it already has the HTTP method name parsing logic in it.

Done too (as you pointed out, I'd reinvented the wheel).

> Now when you say you don't see the field in the decode,
> do you see your debugging printf() output (i.e. did your
> proto_tree_add_item()
> ever get called) ? It looks good to me at the 1st glance...

I get the right amount of prints and with the expected values.
Hmm, now that I think about it, I've not completely implemented
your second suggestion, maybe if I do that, things will start
working.

  Ciao
         Jörg
--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.