[Khachaturov Vassilii <Vassilii.Khachaturov@xxxxxxxxxxxx>]

Hi Joerg,
I'd call this thing method rather than command throughout the code and esp.
the filter names. This way it's closer to the RFC... 

Code-wise you could probably extend the 
is_http_request_or_reply() routine to return you the method string (ether
as a sub-tvb or as a pair of (offset, length) into the line given)
because it already has the HTTP method name parsing logic in it.

Now when you say you don't see the field in the decode,
do you see your debugging printf() output (i.e. did your
proto_tree_add_item()
ever get called) ? It looks good to me at the 1st glance...

Vassilii
> -----Original Message-----
> From: Joerg Mayer [mailto:jmayer@xxxxxxxxx]
> Sent: Friday, August 23, 2002 2:18 PM
> To: ethereal-dev@xxxxxxxxxxxx
> Subject: [Ethereal-dev] Filtering on http commands (help needed)
> 
> 
> Hello List,
> 
> I'm trying add a filter on the http command type (GET, POST etc). So
> I've written the attached patch but I a) don't see this field in the
> decode and b) filtering on http.command == GET or "GET" or 
> 'GET' doesnt
> work. As I'm not sure that this can work at all, I thought I'd ask
> before spending more time on it.